[SG2] Implement transform node builder#7732
Merged
Merged
Conversation
dhsavell
commented
Nov 14, 2022
| @@ -0,0 +1,396 @@ | |||
| using UnityEditor.ShaderFoundry; | |||
|
|
|||
| namespace UnityEditor.ShaderGraph.GraphDelta | |||
Contributor
Author
There was a problem hiding this comment.
This is ported from:
The generation functions have been changed minimally to work with foundry.
Also, some of the names were tweaked to match their surroundings (Util -> Utils to match folder), and some of the unneeded functions/interface implementations were removed.
elizabeth-legros
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR implements a builder for the Transform node with code generation ported from SG1.
The node appears and functions, but since there are no dropdowns yet, it's stuck in the default Object -> World position mode. Uninteresting screenshot:
The UI dropdowns will be added in the next PR.
Testing status